Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved grammar and typo #244

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Improved grammar and typo #244

merged 1 commit into from
Jun 11, 2019

Conversation

antonykamp
Copy link
Contributor

I improved the grammar and the typo in the chapter "Fitting types", especially commas.
I wasn't sure, if you want to use american or british English. In the first case, I only need a message from you, that I can make a new pull request.

Copy link
Collaborator

@pckroon pckroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for helping out!
Only @tBuLi gets to merge PRs though ;)

@tBuLi
Copy link
Owner

tBuLi commented Jun 11, 2019

Hi @ducknrone, thank you for these pull requests, it's very much appreciated! I think we all prefer British English, so I'm going to merge this as is.

@tBuLi tBuLi merged commit a9c8815 into tBuLi:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants