Working Skip support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disabling the built-in skip plugin due to a long-standing defect with the ErrorClassPlugin-based implementation of the skip plugin, that once a test is handled as 'skipped' by the plugin, no other plugin can easily ascertain that a test was skipped. The addSkip method is never called, for example. The easiest workaround is to disable the skip plugin and handle SkipTest exceptions ourselves in addError. A more comprehensive method might be to reimplement the skip test plugin ourselves but it doesn't seem necessary.
|
This looks awesome! I was wondering where the skiptests went. :/ I'll try to give it a poke and merge it in in the next day or two. Thanks! |
|
Oh I should have added, here's a sample of how the new CSS works in my other branch: http://nbviewer.ipython.org/urls/gist.github.com/raw/4281956/e1bc4f2b74b683a2766e791402fda645b076ec62/nb-nose-example.ipynb |
|
Looks great, and I love the new CSS look. Thanks! |
|
Great, thanks. I think this an important project so I'll see what I can do if anything else comes up. |
|
Yup, there'll be a chunk of work coming up with respect to ipython/ipython#2518 . At some point I'll also submit the thing wholesale to ipython so it comes with the stock ipython install. :) (and that might require its own work, too) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the display of skipped tests was not working for me with recent versions of nose. I can go into the details, but what it comes down to is that the way the
SkipPluginworks, as a subclass ofErrorClassPlugins, it consumes skipped tests such that no other plugin can even know they ever existed--theaddSkipmethod is never called either.There are several ways to work around this, but the simplest I can think of is to simply disable the skip plugin and handle
SkipTestexceptions directly in this plugin.This also adds a total of how many tests were skipped, and a bar to the results. The Example notebook is updated to demonstrate the new capability.
I also have a branch at https://github.com/iguananaut/ipython_nose/tree/css-tweaks that was branched off from this change which adds some prettier (IMO) result bars. But I'll defer that until and unless this PR is accepted; otherwise I can tweak it to not depend explicitly on this PR.