Fields: Default filterValue for number field to undefined instead of 0

Fixes: #125
tabalinas · Nov 1, 2016 · ebfc66b · ebfc66b · NiceGuyNimni · Dec 11, 2016
1 parent a821f01
commit ebfc66b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/demos/db.js b/demos/db.js
@@ -5,7 +5,7 @@
         loadData: function(filter) {
             return $.grep(this.clients, function(client) {
                 return (!filter.Name || client.Name.indexOf(filter.Name) > -1)
-                    && (!filter.Age || client.Age === filter.Age)
+                    && (filter.Age === undefined || client.Age === filter.Age)
                     && (!filter.Address || client.Address.indexOf(filter.Address) > -1)
                     && (!filter.Country || client.Country === filter.Country)
                     && (filter.Married === undefined || client.Married === filter.Married);

diff --git a/src/fields/jsgrid.field.number.js b/src/fields/jsgrid.field.number.js
@@ -13,7 +13,9 @@
 		readOnly: false,
 
         filterValue: function() {
-            return parseInt(this.filterControl.val() || 0, 10);
+            return this.filterControl.val()
+                ? parseInt(this.filterControl.val() || 0, 10)
+                : undefined;
         },
 
         insertValue: function() {

diff --git a/tests/jsgrid.field.tests.js b/tests/jsgrid.field.tests.js
@@ -129,7 +129,7 @@ $(function() {
         equal(field.filterTemplate()[0].tagName.toLowerCase(), "input");
         equal(field.insertTemplate()[0].tagName.toLowerCase(), "input");
         equal(field.editTemplate(6)[0].tagName.toLowerCase(), "input");
-        strictEqual(field.filterValue(), 0);
+        strictEqual(field.filterValue(), undefined);
         strictEqual(field.insertValue(), 0);
         strictEqual(field.editValue(), 6);
     });