Skip to content
This repository has been archived by the owner on Dec 20, 2021. It is now read-only.

Feat: Update plume esx to esx legacy #8

Merged
merged 30 commits into from
Aug 19, 2021
Merged

Feat: Update plume esx to esx legacy #8

merged 30 commits into from
Aug 19, 2021

Conversation

Arm-0001
Copy link
Contributor

@Arm-0001 Arm-0001 commented Jul 3, 2021

As the repositories plume depends on were moved into one this pr updates the links. Enjoy ;)

@Scottywonderful
Copy link

This section of the receipe.yaml requires to be updated as per #9

   # Download ESX resources
   - action: download_github
     src: https://github.com/esx-framework/es_extended
     ref: 694cd6757802c432bd025f8251dee33760080eff
     dest: ./resources/[esx]/es_extended

@Arm-0001
Copy link
Contributor Author

Arm-0001 commented Jul 3, 2021

This section of the receipe.yaml requires to be updated as per #9

   # Download ESX resources
   - action: download_github
     src: https://github.com/esx-framework/es_extended
     ref: 694cd6757802c432bd025f8251dee33760080eff
     dest: ./resources/[esx]/es_extended

this isnt needed as its all included in the esx legacy repo

@Scottywonderful
Copy link

Scottywonderful commented Jul 3, 2021

This section of the receipe.yaml requires to be updated as per #9

   # Download ESX resources
   - action: download_github
     src: https://github.com/esx-framework/es_extended
     ref: 694cd6757802c432bd025f8251dee33760080eff
     dest: ./resources/[esx]/es_extended

this isnt needed as its all included in the esx legacy repo

Yeah, after posting this, I notice you removed it in the request and updating it to the https://github.com/esx-framework/esx-legacy framework github, which I believe is a great idea, being it has been the most popular download for esx folders used recently.

server.cfg Outdated Show resolved Hide resolved
@Arm-0001 Arm-0001 marked this pull request as ready for review July 4, 2021 21:27
@thelindat
Copy link

The Legacy repo has everything, some of which wouldn't be recommended such as

  • esx_voice
  • esx_phone
  • esx_whitelist

Some resources need their config modified as well such as enabling identiy/society integration, or enabling multicharacter in the ESX config.

Copy link
Owner

@tabarra tabarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change requests :)

plume.sql Outdated Show resolved Hide resolved
plume.sql Show resolved Hide resolved
README.md Show resolved Hide resolved
loadingscreen/config.js Show resolved Hide resolved
server.cfg Outdated Show resolved Hide resolved
recipe.yaml Outdated Show resolved Hide resolved
recipe.yaml Outdated Show resolved Hide resolved
recipe.yaml Outdated Show resolved Hide resolved
recipe.yaml Outdated Show resolved Hide resolved
recipe.yaml Show resolved Hide resolved
@Arm-0001
Copy link
Contributor Author

alright all changes done

@tabarra tabarra merged commit 5586120 into tabarra:main Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants