Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vietnamese translation. #693

Merged
merged 8 commits into from
Dec 2, 2022
Merged

Update vietnamese translation. #693

merged 8 commits into from
Dec 2, 2022

Conversation

nkyo
Copy link
Contributor

@nkyo nkyo commented Oct 10, 2022

create vi.json for vietnamese translation

Nam Kyo added 2 commits October 10, 2022 22:33
Create vi.json for vietnameses translation
@nkyo nkyo requested a review from tabarra as a code owner October 10, 2022 15:34
@nkyo nkyo closed this Oct 10, 2022
@nkyo nkyo reopened this Oct 10, 2022
@tabarra
Copy link
Owner

tabarra commented Oct 10, 2022

Thanks, I'll have a look in a couple of weeks when the next update is ready

@tabarra tabarra changed the base branch from master to develop November 8, 2022 15:40
@tabarra
Copy link
Owner

tabarra commented Nov 14, 2022

Hey @nkyo I just reviewed the translation and found some errors.
Could you please edit the label to bel Vietnamese and check the following keys below?

Keys validation failed on:
- nui_menu.misc.no_perms
- nui_menu.page_main.announcement.label
- nui_menu.page_main.clear_area.label
- nui_menu.page_main.clear_area.dialog_desc
- nui_menu.page_main.player_ids.label
- nui_menu.player_modal.ban.submit
- nui_menu.misc.action_unauthorized
- nui_menu.misc.general_no_perms
- nui_menu.page_main.clear_area.dialog_description

@tabarra
Copy link
Owner

tabarra commented Nov 14, 2022

Thanks again for the PR.
I just modified a few lines to prepare for the v5 update, if you don't mind, can you also translate those?
https://github.com/tabarra/txAdmin/blob/develop/locale/en.json

edit: don't forget to target your PR to the develop branch :)

@nkyo
Copy link
Contributor Author

nkyo commented Nov 22, 2022

@tabarra I updated V5 translation.

@tabarra
Copy link
Owner

tabarra commented Dec 2, 2022

Thanks for the translation.
I just modified humanizer_language from vn to vi.

@tabarra tabarra merged commit 6d467a8 into tabarra:develop Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants