fix(menu/player-modal): resolve loading issues & state refactor #716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More gracefully handle the loading process for the player modal, instead of through the global suspense fallback. This PR also refactors the provider to not hold any of modal state, instead opting to store it within Recoil.
Also includes some miscellaneous cleanup. See below for comparison with mocked loading times of 300ms
Before
After