Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convar for plateChange #729

Closed
wants to merge 2 commits into from
Closed

Convar for plateChange #729

wants to merge 2 commits into from

Conversation

TheFarFantomas
Copy link

No description provided.

@tabarra tabarra added the menu label Jan 31, 2023
@tabarra
Copy link
Owner

tabarra commented Jul 3, 2023

After 7 months, do you still think this is required or the other resources already adapted?

@ChatDisabled
Copy link
Contributor

other resources already adapted

Kinda is hard for third party resources to do this. Unless they listen to txsv:logger:menuEvent event, which too be fair no one is going to do. Considering txAdmin itself changes so it's only fair for the resource to change it back as well. Either a convar and or saving the previous plate and putting it back wouldn't be a bad idea.

@tabarra
Copy link
Owner

tabarra commented Jul 10, 2023

With the help of @ChatDisabled (in DMs) I decided to just remove this plate-changing novelty feature.
Therefore, this PR is not needed anymore.

@tabarra tabarra closed this Jul 10, 2023
tabarra added a commit that referenced this pull request Jul 11, 2023
@tabarra
fix(menu): removed car plate change on boost
4b62e8e 
Related to #729.
This vanity feature was affecting roleplay garage resources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabarra tabarra Awaiting requested review from tabarra tabarra is a code owner

Assignees
No one assigned
Labels
menu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TheFarFantomas @tabarra @ChatDisabled