Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescale UI Elements for 4K Displays #870

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

frvgs
Copy link

@frvgs frvgs commented Sep 6, 2023

I'm used to playing on 4k screens and the Menu UI was almost unreadable

as described in this issue I used media queries targeting displays with a min-height of 2160px to rescale the Menu

Tested UI elements on both standard and 4K resolutions and verified that UI adjustments are applied only on displays with a height of 2160px or greater.

before
before

after
after

@frvgs frvgs requested a review from tabarra as a code owner September 6, 2023 10:10
@tabarra
Copy link
Owner

tabarra commented Sep 6, 2023

That's awesome, thanks.
@TasoOneAsia mind reviewing it?

@iSentrie
Copy link

iSentrie commented Sep 6, 2023

image

@frvgs
Copy link
Author

frvgs commented Sep 6, 2023

mb, those weren't the right screenshots, here's what it looks like before and after the rescale on 4k displays :

before
before
after rescale
after2

@iSentrie
Copy link

iSentrie commented Sep 6, 2023

a bit weird that font size differs
image
should be
image

@frvgs
Copy link
Author

frvgs commented Sep 6, 2023

a bit weird that font size differs image should be image

Thank you for your feedback, it's fixed

textfix

@tabarra tabarra added the enhancement New feature or request label Sep 10, 2023
@tabarra tabarra added bug Something isn't working and removed enhancement New feature or request labels Dec 30, 2023
@tabarra
Copy link
Owner

tabarra commented Jan 11, 2024

Hey @frvgs, thanks for the PR.
With txAdmin v7 and new UI, there is a chance that soon I'll migrate the ingame UI to use the same library and visual styles of the web UI, and with that, everything will be measured in REM units, solving this issue properly.

As of now, I'm not sure if this will be done, or when this will be done, so I'll leave this PR open in case I decide to merge it instead.

@Z3rio
Copy link

Z3rio commented Jul 10, 2024

Hey @frvgs, thanks for the PR. With txAdmin v7 and new UI, there is a chance that soon I'll migrate the ingame UI to use the same library and visual styles of the web UI, and with that, everything will be measured in REM units, solving this issue properly.

As of now, I'm not sure if this will be done, or when this will be done, so I'll leave this PR open in case I decide to merge it instead.

Yep ^^ This should be one of the better solutions.
To turn all px -> rem, and then just update the rem unit at the head object.
Way less hacky than this, and more uniform!

I could perhaps help out with this if I have some time over

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants