Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(menu): add keymapping for tp to waypoint #886

Closed
wants to merge 2 commits into from
Closed

feat(menu): add keymapping for tp to waypoint #886

wants to merge 2 commits into from

Conversation

btwlouis
Copy link

@btwlouis btwlouis commented Dec 3, 2023

This pull request introduces a Key Mapping feature for teleporting to waypoints. Users can now easily assign keys to the teleportation process.

not tested, but should work fine

@tabarra
Copy link
Owner

tabarra commented Dec 3, 2023

Now i'm wondering... why haven't I added optional keymappings to most menu features?!
I'm thinking there was probably a reason, like Cfx saying that there was a limit or something because it's a default resource?!

🤔

@btwlouis
Copy link
Author

btwlouis commented Dec 3, 2023

Now i'm wondering... why haven't I added optional keymappings to most menu features?! I'm thinking there was probably a reason, like Cfx saying that there was a limit or something because it's a default resource?!

🤔

So I don't know that there is a limit, esx uses more than 3 in its latest version and it runs without any problems.

@Mycroft-Studios
Copy link
Contributor

Mycroft-Studios commented Dec 3, 2023 •
edited

So I don't know that there is a limit, esx uses more than 3

ESX isnt a default resource. by "default" tabby is referring to resources that are bundled with the fxserver and/or cfx made (such as chat)

@tabarra tabarra added the enhancement New feature or request label Jan 13, 2024
tabarra added a commit that referenced this pull request Feb 21, 2024
@tabarra
feat(menu): add keymapping for tp to waypoint (#886)
2a06c81 
commit 9253025f8e4884f436244d3cd6e491f2520dafc1
Author: btwlouis <56355239+btwlouis@users.noreply.github.com>
Date:   Sun Dec 3 15:15:12 2023 +0100

    add: waypoint command to suggestions remove

commit 1b0f543d4ce2b7bdeb5d95fee2058aa597cc74b8
Author: btwlouis <56355239+btwlouis@users.noreply.github.com>
Date:   Sun Dec 3 11:53:00 2023 +0000

    feat(menu): add keymapping for tp to waypoint
@tabarra
Copy link
Owner

tabarra commented Feb 21, 2024

Huh... apparently my local squash merge didn't detect this as merged.
Either ways, thanks for the PR!

@tabarra tabarra closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mycroft-Studios Mycroft-Studios Mycroft-Studios left review comments

@tabarra tabarra Awaiting requested review from tabarra tabarra is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request merged manually
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@btwlouis @tabarra @Mycroft-Studios