Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG FIX] Server log in web panel will now reconnect when entering live mode #935

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

AleksanderEvensen
Copy link
Contributor

Resolves bug report: #921

The socket was disconnected once checking out previous logs, but was never reconnected upon entering live mode again.
I also moved the event listeners outside the goLive function since it would add duplicate listeners on logData.

brave_R0ktt0GhBg.mp4

@tabarra
Copy link
Owner

tabarra commented Apr 1, 2024

Thank you for the PR.

@tabarra tabarra changed the base branch from master to develop April 1, 2024 04:29
@tabarra tabarra merged commit ca3ee54 into tabarra:develop Apr 1, 2024
@AleksanderEvensen AleksanderEvensen deleted the fix/server-log-socket branch April 1, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants