Make webidl win over ecmascript, and infra win over i18n-glossary again #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebIDL creates proxy definitions of `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`, `TypeError`, and `URIError` that are initially defined in ECMAScript. The WebIDL definitions are typically preferred in web spec to reference the concepts. A previous commit made the Infra standard win over the Internationalization glossary but that change was accidently rolled back by the following data refresh: speced@163bc60
|
Man what the HELL I committed that change twice, how did it revert itself again??? Thanks for noticing.
It does, yes. I was waiting to do a bit more work first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous commit made the Infra standard win over the Internationalization glossary but that change was accidently (or at least, I suppose that was not intended ;)) rolled back by the data refresh that followed: 163bc60
The other case that seems to warrant a new rule is WebIDL and ECMAScript: WebIDL creates proxy definitions of
EvalError,RangeError,ReferenceError,SyntaxError,TypeError, andURIErrorthat are otherwise defined in ECMAScript. The WebIDL definitions are typically preferred in web spec to reference the concepts. Other ECMAScript definitions that are redefined in other specs (e.g. "realm" in HTML) are typically namespaced and shouldn't create particular problems.(Side note that a new version of Bikeshed probably needs to be issued for changes to propagate to bikeshed-data. Nothing urgent on my side, just in case that fell through the cracks! :))