You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm willing to make this change in my version of the codebase and make a PR on your project backporting only this change, but only if you accept the idea.
The reason for this is that I don't want to continue to maintain a fork too different from your codebase, and this looks a rather important change; I therefore won't take the rist to make the update on my side if you don't commit on the idea first.
Would you be ok to merge such a pull request if I made one?
The text was updated successfully, but these errors were encountered:
I'm fine with adding this kind of API, but the reason I have the functions named as they are is to just match the spec's algorithm names. There's also some functions that don't map directly to a type (like consumeAListOfDeclarations.
Yes, I did see the consume functions for which no type existed, and I was planning to create fake ones for them.
I'm fine with keeping the old function names as aliases, the only intent is to make it easier to understand what's going; for instance it's hard to know right now that the "value" of an AtRule is a SimpleBlock; if the parsing function was closer to the declaration help understand the intent better, I think.
I'll work on that sometime this week, maybe Wednesday.
I'm willing to make this change in my version of the codebase and make a PR on your project backporting only this change, but only if you accept the idea.
The reason for this is that I don't want to continue to maintain a fork too different from your codebase, and this looks a rather important change; I therefore won't take the rist to make the update on my side if you don't commit on the idea first.
Would you be ok to merge such a pull request if I made one?
The text was updated successfully, but these errors were encountered: