WIP: feat(Settings): added settings layout comp #77
Conversation
Fixed design on general settings
|
👍 |
| @@ -35,14 +42,27 @@ const Header: React.FC<HeaderProps> = ({ children, links = [] }) => { | |||
| to={link.to} | |||
| key={i} | |||
| activeStyle={{ | |||
| color: '#1D1D1D', | |||
There was a problem hiding this comment.
Should this be added to theme.colors maybe? Maybe you can decide, @AnneMatilde?
There was a problem hiding this comment.
Please replace the color #1D1D1D with #1B202E.
| <OptionView | ||
| completedText="Valgt" | ||
| contentName="IBM Plex Sans + IBM Plex Serif" | ||
| loadingText="Bruk" | ||
| onPreviewClick={handleFontPreview} | ||
| onSelectClick={handleFontChoose} | ||
| previewText="Forhåndsvis" | ||
| > | ||
| <></> | ||
| </OptionView> | ||
| <OptionView | ||
| completedText="Valgt" | ||
| contentName="IBM Plex Sans + IBM Plex Serif" | ||
| loadingText="Bruk" | ||
| onPreviewClick={handleFontPreview} | ||
| onSelectClick={handleFontChoose} | ||
| previewText="Forhåndsvis" | ||
| > | ||
| <></> | ||
| </OptionView> | ||
| <OptionView | ||
| completedText="Valgt" | ||
| contentName="Work Sans + Roboto" | ||
| loadingText="Bruk" | ||
| onPreviewClick={handleFontPreview} | ||
| onSelectClick={handleFontChoose} | ||
| previewText="Forhåndsvis" | ||
| > |
There was a problem hiding this comment.
This should probably be a list that we can pull for the API. For now, we can add it as an array, but later @dem1k can add that to the backend, what do you say?
There was a problem hiding this comment.
I think the best option for this is create list component in Kit project, like we did with checkboxlist. I thinking about create an array which I will pass in parameters as a variant
|
@TanyaDolgopolova You can merge stuff on your own, when you've got the reviews you need :) |
|
Hi @TanyaDolgopolova! Have you finished with the design implementation for this? |
This is still in progress. I will add this list of views to the kit project and connect it to this component. For now I left it like that |
|
This is still WIP, correct? Can you add a |
It still in progress. I will add it |
TanyaDolgopolova
changed the title
TanyaDolgopolova
changed the title
simenandre
changed the title
|
This has become stale, closing it. Reopen if need be. 👍 |
Fixed design on general settings
Close #16
Close #55