Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could not connect to the remote Jenkins when password contains # #41

Closed
VitekVlcek-Broadcom opened this issue Dec 1, 2020 · 2 comments
Closed

Could not connect to the remote Jenkins when password contains # #41

VitekVlcek-Broadcom opened this issue Dec 1, 2020 · 2 comments
Assignees
@tabeyti
Labels
bug Something isn't working
Milestone
1.1.1

Comments

@VitekVlcek-Broadcom
Copy link

When a password starts with # then I get Could not connect to the remote Jenkins

Developer console reveals

Using the following URI for Jenkins client: http://abc123:#password+-@jenkins3.acme.net
console.ts:137 [Extension Host] Refreshing Pipeline step auto-completions.
console.ts:137 [Extension Host] RequestError: Error: getaddrinfo ENOTFOUND abc123 
   at new RequestError (/home/XXX/.vscode-server/extensions/tabeyti.jenkins-jack-1.1.0/node_modules/request-promise-core/lib/errors.js:14:15)	
   at Request.plumbing.callback (/home/XXX/.vscode-server/extensions/tabeyti.jenkins-jack-1.1.0/node_modules/request-promise-core/lib/plumbing.js:87:29)

There is a workaround:
When I replace # with %23 in password in settings.json, then I can connect.
@tabeyti tabeyti added the bug Something isn't working label Dec 2, 2020
@tabeyti tabeyti self-assigned this Dec 2, 2020
@tabeyti tabeyti added this to the 1.1.1 milestone Dec 2, 2020
tabeyti added a commit that referenced this issue Dec 2, 2020
@tabeyti
fixing uri encoding issue with passwords
ef79998 
#41
@tabeyti
Copy link
Owner

tabeyti commented Dec 3, 2020

Hey @VitekVlcek-Broadcom

This should now be fixed in 1.1.1. If you could please validate the fix for me, I'd appreciate it.

@VitekVlcek-Broadcom
Copy link
Author

yes, 1.1.1 fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tabeyti tabeyti

Labels
bug Something isn't working
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
2 participants
@tabeyti @VitekVlcek-Broadcom