Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code coverage to PRs. #183

Merged
merged 5 commits into from Feb 16, 2019
Merged

Add code coverage to PRs. #183

merged 5 commits into from Feb 16, 2019

Conversation

jnegara
Copy link
Contributor

@jnegara jnegara commented Feb 15, 2019 •
edited

  • Now running tests with coverage.
  • Added coveralls check to CI.

Code coverage should now be reported in PRs (as demonstrated in this one). :)

@jnegara jnegara added the WIP Work in progress label Feb 15, 2019
@jnegara jnegara changed the base branch from master to dev February 15, 2019 19:52
@jnegara jnegara removed the WIP Work in progress label Feb 16, 2019
@jnegara jnegara self-assigned this Feb 16, 2019
@0golovatyi 0golovatyi merged commit a0475c7 into dev Feb 16, 2019
@0golovatyi 0golovatyi deleted the add-coveralls branch February 16, 2019 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0golovatyi 0golovatyi 0golovatyi approved these changes

@johng42 johng42 Awaiting requested review from johng42

@sbabayan sbabayan Awaiting requested review from sbabayan

@tmartintableau tmartintableau Awaiting requested review from tmartintableau

Assignees

@jnegara jnegara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnegara @0golovatyi