Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for set_credentials in tabpy-tools. #248

Merged
merged 7 commits into from Apr 5, 2019
Merged

Unit tests for set_credentials in tabpy-tools. #248

merged 7 commits into from Apr 5, 2019

Conversation

jnegara
Copy link
Contributor

@jnegara jnegara commented Apr 4, 2019

Added unit tests for the new set_credentials methods in tabpy-tools.

@jnegara jnegara self-assigned this Apr 4, 2019
@pep8speaks
Copy link

pep8speaks commented Apr 4, 2019 •
edited

Hello @jnegara! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-04-04 22:51:56 UTC

@jnegara jnegara added the WIP Work in progress label Apr 4, 2019
@jnegara jnegara changed the title Unit tests for set_credentials in tabpy-tools. WIP: Unit tests for set_credentials in tabpy-tools. Apr 4, 2019
0golovatyi
0golovatyi approved these changes Apr 4, 2019
View reviewed changes
tabpy-tools/tabpy_tools/rest.py Show resolved Hide resolved
@jnegara jnegara changed the title WIP: Unit tests for set_credentials in tabpy-tools. Unit tests for set_credentials in tabpy-tools. Apr 4, 2019
@jnegara jnegara removed the WIP Work in progress label Apr 4, 2019
@0golovatyi 0golovatyi merged commit f0f34ec into dev Apr 5, 2019
johng42
johng42 approved these changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@johng42 johng42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@0golovatyi 0golovatyi deleted the dev_tools_creds_tests branch April 5, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0golovatyi 0golovatyi 0golovatyi approved these changes

@johng42 johng42 johng42 approved these changes

@sbabayan sbabayan sbabayan approved these changes

@tmartintableau tmartintableau tmartintableau approved these changes

Assignees

@jnegara jnegara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jnegara @pep8speaks @johng42 @sbabayan @0golovatyi @tmartintableau