Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weren't setting the path properly for the optional config parameter #252

Merged
merged 4 commits into from
Apr 10, 2019
Merged

weren't setting the path properly for the optional config parameter #252

merged 4 commits into from
Apr 10, 2019

Conversation

sbabayan
Copy link
Contributor

@sbabayan sbabayan commented Apr 9, 2019

Manually tested on both Mac & Windows creating a temporary config file and passing it in on startup

@sbabayan sbabayan added the bug label Apr 9, 2019
0golovatyi
0golovatyi requested changes Apr 9, 2019
View reviewed changes
startup.cmd Outdated Show resolved Hide resolved
johng42
johng42 reviewed Apr 9, 2019
View reviewed changes
startup.cmd Outdated Show resolved Hide resolved
johng42
johng42 suggested changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@johng42 johng42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the doc file as well?

@pep8speaks
Copy link

pep8speaks commented Apr 10, 2019 •
edited

Hello @sbabayan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-04-10 21:21:34 UTC

0golovatyi
0golovatyi requested changes Apr 10, 2019
View reviewed changes
tabpy-server/tabpy_server/app/app.py Outdated Show resolved Hide resolved
@sbabayan sbabayan merged commit 52546eb into dev Apr 10, 2019
@0golovatyi 0golovatyi deleted the config-bug-895453 branch April 10, 2019 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johng42 johng42 johng42 approved these changes

@0golovatyi 0golovatyi 0golovatyi approved these changes

@tmartintableau tmartintableau tmartintableau approved these changes

@jnegara jnegara Awaiting requested review from jnegara

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sbabayan @pep8speaks @johng42 @0golovatyi @tmartintableau