add test to validate info response with auth off #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since this actually goes through tornado this should be sufficient for E2E to validate the info response for auth on (already tested) and auth off (this test)
0golovatyi
approved these changes
Apr 10, 2019
build fails w/o bytes being specified - a bytes like object is needed
WillAyd
reviewed
Apr 11, 2019
| cls.config_file = tempfile.NamedTemporaryFile( | ||
| prefix=prefix, suffix='.conf', delete=False) | ||
| cls.config_file.write( | ||
| bytes( |
There was a problem hiding this comment.
Rather than creating bytes here you could just open the file in w+ mode to write strings
0golovatyi
approved these changes
Apr 11, 2019
0golovatyi
approved these changes
Apr 11, 2019
|
@johng42 build failed |
jnegara
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since this actually goes through tornado this should be sufficient for E2E to validate the info response for auth on (already tested) and auth off (this test)