Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.9.0: Fix model deployement with removing usage of pip._internal #398

Merged
merged 2 commits into from
Jan 31, 2020

Conversation

0golovatyi
Copy link
Contributor

v0.9.0

Improvements

  • Models deployment doesn't depend on pip._internal anymore.
  • Package size reduced.

Copy link
Contributor

@sbabayan sbabayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the documentation in "Deploying Models Shipped With TabPy"

Copy link
Contributor

@sbabayan sbabayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused, if deploying a model just adds a new endpoint and pickled file, can't we just add that to Tabpy itself so that users don't need to deploy anything anymore?

@0golovatyi
Copy link
Contributor Author

I'm a little confused, if deploying a model just adds a new endpoint and pickled file, can't we just add that to Tabpy itself so that users don't need to deploy anything anymore?

I don't think pickled files are portable, plus deployed models update Tornado config which may have other models in it already and we want to append, not replace Tornado config.
The better solution would be not to have deploy models with Tornado and tabpy_tools but rather install them as packages with pip.

@0golovatyi
Copy link
Contributor Author

Please update the documentation in "Deploying Models Shipped With TabPy"

Thanks for reminding me. Updated.

@0golovatyi 0golovatyi merged commit 65b0bca into master Jan 31, 2020
@0golovatyi 0golovatyi deleted the hotfix_pip branch January 31, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v1
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants