-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TagsField is case-sensitive #130
Comments
Thanks for the report! I'm hesitant to modify the existing TagField class but I'd definitely be open to adding a similar |
That seems fine. Explicit being better than implicit and all that. My only thought is whether AWS is moving to the lowercase example for future APIs. In which case a Happy with the proposed solution. |
A further thought after sleeping in it: at the moment, if the lowercase |
Sounds good. Due to other obligations and vacation it's fairly unlikely I'll be able to work on this until August 9th at the earliest but feel free to submit a PR if you end up implementing it. |
API Gateway domain names (and other API Gateway resources tbh) have their keys set to all lowercase letters. (an example can be seen in the response here: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/apigateway.html#APIGateway.Client.get_domain_names)
Because
TagsField
defaults tooptional=True
, the lowercase key will be missed and the tags will be empty.The text was updated successfully, but these errors were encountered: