Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lpg #151

Closed
wants to merge 3 commits into from
Closed

Fix lpg #151

wants to merge 3 commits into from

Commits on Feb 3, 2022

  1. Use string type in edge ids instead of uuid 

    Neptune does not support the uuid type, so in order to ensure all
the ids of the edges are strings before writing them to Neptune
we directly use convert the uuid's to strings when setting the id's
of the edges when transforming the graph to Neptune.
    @manelmontilla
    manelmontilla committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    b188322 View commit details
    Browse the repository at this point in the history

  2. Avoid generating TagLink ids ending with a colon 

    When writing edges to Neptune in lpg mode, if a "from" or a "to" vertex does not
exist, it's created. The label of those vertices is determined
by calling the function: "parse_arn" with the id of the vertex to be created.
The problem is the function returns empty is the value passed in has the
following shape: "value:". As empty labels are not supported
by Neptune that causes and error when writing the edge.
    @manelmontilla
    manelmontilla committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    ca64e4e View commit details
    Browse the repository at this point in the history

  3. Ensure the arn's written to Neptune are not of the type uuid

    @manelmontilla
    manelmontilla committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    b3ce831 View commit details
    Browse the repository at this point in the history