Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Query Band Read/Write Support #109

Closed
r-richmond opened this issue Nov 3, 2016 · 3 comments
Closed

Request: Query Band Read/Write Support #109

r-richmond opened this issue Nov 3, 2016 · 3 comments

Comments

@r-richmond
Copy link
Contributor

Certain Datasources have query bands and it would be extremely helpful to be able to modify these programatically.

@t8y8
Copy link
Contributor

t8y8 commented Nov 3, 2016

@r-richmond Thank you for opening a request!

Would it be possible to include a dummy-tds or twb that already has a query band in it?
It would also be great to include a sample query band update you might make.
It's very helpful for us when building test cases and understand the requirements.

(I'm marking this as an enhancement)

@r-richmond
Copy link
Contributor Author

Sure,

I've attached a dummy workbook that contains both sample query bands & sample initial sql.

As far as an example use case. I would like to be able to write something like

for workbook in folder:
  for datasource in workbook:
    if datasource.query_band is none:
      datasource.query_band = 'TableauReport=<workbookname>';
   elif datasource.query_band does not contain 'TableauReport=<workbookname>':
      datasource.query_band += '\n TableauReport=<workbookname>';

note: in this case I'd like to be the special value that you can use in query bands now and not a hardcoded string of the current workbook name.

bands_initial_dummy_workbook.twb.zip

t8y8 pushed a commit that referenced this issue Jan 9, 2017
graysonarts pushed a commit that referenced this issue Jan 11, 2017
* Fix #117 by only attempting files with the right extension inside the archive (#118)

* Commenting and Docstring cleanup. A few very small code cleanups (#120)

Add docstrings and remove clutter. I also made some very tiny tweaks to some code for clarity.

* Small cleanups for various editors. Play nice with built in test-runners (#121)

* Add Py36, update travis to use pycodestyle (#124)

* Add `initial sql` and `query band` support (#123)

Addresses #109 and #110

* Prep for release of 0.6 (#125)

* Prep for release of 0.6

* wordsmithing the changelog
@r-richmond
Copy link
Contributor Author

Marking this as closed with release 0.6 & the merging of #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants