Refactors suggested in last PR. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat always returns a list of connections. In the legacy case it's just a list of one, in the federated case it's all of them (in order they are in the twb). This gives folks a consistent API. Updated tests to match, and the example and README as well
This was referenced May 17, 2016
eldang
added a commit
to eldang/tableau_tools
that referenced
this pull request
Jun 15, 2017
…ng the first in the list cf tableau/document-api-python#10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now there is a connections property that always returns a list of connections.
In the legacy case it's just a list of one, in the federated case it's all of them (in order they are in the twb). This gives folks a consistent API for the future.
Updated tests to match. Examples and README as well.
Tests pass on my Mac in Py2 and Py3