-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Connection, NamedConnection and Relation classes #204
Conversation
* Added new relation entity and to_dict() methods. * More tidying.
* Added new relation entity and to_dict() methods. * More tidying. * Minor tweaks.
Interesting! Could you please submit a Contributor License Agreement described here: https://tableau.github.io/contributing.html? |
Any update on this? Would love to be able to use the new relation class. |
Unfortunately we absolutely can't merge code from someone who hasn't agreed to our CLA. Hopefully @kgpayne is still available and might come back to sign it and submit! |
But I can switch the PR to branch from development instead of master, and I'll try and add some tests for it so it's easier to finish if they do come back. |
Completely understandable @jacalata - wasn’t sure if CLA had been signed. Thank you though! |
Hey 👋 Thanks for checking this out! I recently moved roles, and am no longer at |
Thanks for the contribution! Before we can merge this, we need @kgpayne to sign the Salesforce.com Contributor License Agreement. |
4875132
to
5ddf93f
Compare
Hi @alanmcruickshank - are you interested/able to sign a CLA so I could merge this work into the tool? I don't think the bot is smart enough to understand that, so we might just need it over email. |
@jacalata - sure thing. Devraj Toor is our new tableau account rep so he can probably facilitate some document signing and has my email address 👍 . |
I finally actually pinged Dev so hopefully will get this wrapped up soon |
Any updates here? Am interested in the relation class too. |
Closing as approaching 2 years old and very stale 🤷♂️ |
New Connection, NamedConnection and Relation classes, added to support extraction of metadata via tap-tableau-server. From the readme: