Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial test of an alert applies a 30 second timeout rather than configured timeout #3

Closed
mcoles opened this issue Dec 8, 2015 · 1 comment
Labels

Comments

@mcoles
Copy link
Contributor

mcoles commented Dec 8, 2015

When a user subscribes to a View on an Alert schedule, the first time VizAlerts tests it on the schedule, the timeout value used is 30 seconds. This can cause problems for longer running views, and is especially unhelpful when the alert is to be run daily or weekly, as these can be alotted longer timeouts than normal, and the subscriber will need to go longer with no good information from their initial alert.

The fix should probably be to derive a fake "last ran at" time from the schedules table in the PostgreSQL repository, which would provide a more-valid value to apply the timeout rules by. For example, for an alert that runs daily, but has never run before, we can provide now() minus 24 hours as the last_ran_at time, which would cause it to use a rule matching 86400 seconds, instead of 1800 (30 minutes). That'd allow it a 5 minute timeout under the default config, instead of 30 seconds.

@mcoles mcoles added the bug label Jan 14, 2016
mcoles pushed a commit that referenced this issue Apr 5, 2016
@mcoles
Copy link
Contributor Author

mcoles commented Apr 6, 2016

Added into bug fixes branch, will integrate from there into dev, then master. Closing issue!

@mcoles mcoles closed this as completed Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant