Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable @typescript-eslint/no-unsafe-assignment where any is allowed #104

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

SimeonC
Copy link
Collaborator

@SimeonC SimeonC commented Jan 30, 2024

const a: any;
const b = a; // throws eslint error

In this scenario, usually we should avoid this. In the case of tests, typescript definition files and storybook, we allow any so it makes sense to turn off this rule.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/frontend-audit@6.0.1-canary.104.7707943839.0
npm install @tablecheck/commitlint-config@6.0.1-canary.104.7707943839.0
npm install @tablecheck/eslint-config@8.2.5-canary.104.7707943839.0
npm install @tablecheck/eslint-plugin@6.1.2-canary.104.7707943839.0
npm install @tablecheck/semantic-release-config@7.0.1-canary.104.7707943839.0
# or 
yarn add @tablecheck/frontend-audit@6.0.1-canary.104.7707943839.0
yarn add @tablecheck/commitlint-config@6.0.1-canary.104.7707943839.0
yarn add @tablecheck/eslint-config@8.2.5-canary.104.7707943839.0
yarn add @tablecheck/eslint-plugin@6.1.2-canary.104.7707943839.0
yarn add @tablecheck/semantic-release-config@7.0.1-canary.104.7707943839.0

Copy link

github-actions bot commented Jan 30, 2024

Unit Test Results

    1 files      3 suites   24s ⏱️
201 tests 201 ✔️ 0 💤 0
219 runs  219 ✔️ 0 💤 0

Results for commit e3b63a7.

♻️ This comment has been updated with latest results.

@SimeonC SimeonC added the patch Increment the patch version when merged label Jan 30, 2024
@SimeonC SimeonC force-pushed the narrow-typescript-eslint-no-unsafe-assignment-scope branch from 4362ec0 to 47d757d Compare January 30, 2024 07:53
@SimeonC SimeonC enabled auto-merge (rebase) January 30, 2024 10:08
@SimeonC SimeonC merged commit f330eb0 into main Jan 31, 2024
5 checks passed
@SimeonC SimeonC deleted the narrow-typescript-eslint-no-unsafe-assignment-scope branch January 31, 2024 01:49
@tablecheck-public-automation tablecheck-public-automation added the released This issue/pull request has been released. label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants