feat: allow _destroy as a property
#108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_destroy: true` property is used as a special key in monolith/ruby-on-rails APIs to indicate that the sub-record should be destroyed so we should allow this specific exception.
SimeonC
force-pushed
the
allow-_destroy-properties
branch
from
0c200d7
to
791ee3c
Compare
k-baldauf
approved these changes
Apr 1, 2024
whanchong
approved these changes
Apr 1, 2024
|
🚀 PR was released in |
tablecheck-public-automation
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_destroy: trueproperty is used as a special key in monolith/ruby-on-rails APIs to indicate that the sub-record should be destroyed so we should allow this specific exception.We have a ton of "eslint-disable" comments related to this in our repos.
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @tablecheck/eslint-config@8.5.0-canary.108.8504387473.0 # or yarn add @tablecheck/eslint-config@8.5.0-canary.108.8504387473.0