Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): cypress component testing + razzle config #18

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

SimeonC
Copy link
Collaborator

@SimeonC SimeonC commented Aug 18, 2021

Update razzle sspa config to inject the app version into manifest automaticaly.
Add shared cypress component testing configuration utils and fixing some eslint rules for cypress.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/eslint-config@1.2.0-canary.18.4e7d008cbb4e314d16bcce66958948b9156cc753.0
npm install @tablecheck/scripts@1.2.0-canary.18.4e7d008cbb4e314d16bcce66958948b9156cc753.0
# or 
yarn add @tablecheck/eslint-config@1.2.0-canary.18.4e7d008cbb4e314d16bcce66958948b9156cc753.0
yarn add @tablecheck/scripts@1.2.0-canary.18.4e7d008cbb4e314d16bcce66958948b9156cc753.0

@SimeonC SimeonC added the patch Increment the patch version when merged label Aug 18, 2021
@github-actions
Copy link

github-actions bot commented Aug 18, 2021

Unit Test Results

  2 files    9 suites   8s ⏱️
56 tests 56 ✔️ 0 💤 0 ❌

Results for commit b0d5e01.

♻️ This comment has been updated with latest results.

@SimeonC SimeonC changed the title feat(scripts): add support for cypress component testing feat(scripts): cypress component testing + razzle config Aug 18, 2021
@SimeonC SimeonC force-pushed the support-cypress-component-testing branch 4 times, most recently from 92aecac to 6229893 Compare August 19, 2021 04:02
@SimeonC SimeonC added minor Increment the minor version when merged and removed patch Increment the patch version when merged labels Aug 19, 2021
@SimeonC SimeonC self-assigned this Aug 19, 2021
gazpachu
gazpachu previously approved these changes Aug 19, 2021
Update razzle sspa config to inject the app version into manifest automaticaly.
Add shared cypress component testing configuration utils and fixing some eslint rules for cypress.
@SimeonC SimeonC requested a review from gazpachu August 19, 2021 06:21
@SimeonC SimeonC merged commit 26d96bc into main Aug 19, 2021
@SimeonC SimeonC deleted the support-cypress-component-testing branch August 19, 2021 06:28
@SimeonC
Copy link
Collaborator Author

SimeonC commented Aug 20, 2021

🚀 PR was released in @tablecheck/eslint-config@1.2.0, @tablecheck/scripts@1.2.0 🚀

@SimeonC SimeonC added the released This issue/pull request has been released. label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants