Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eslint plugin can't find tsconfig in precommit #29

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

SimeonC
Copy link
Collaborator

@SimeonC SimeonC commented Oct 6, 2021

Sometimes the lint-staged eslint couldn't find the cypress configs correctly, this fixes that issue.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/eslint-config@1.5.1-canary.29.efab3d29f4cf489567f85982e3735009bb6db61a.0
npm install @tablecheck/scripts@1.6.1-canary.29.efab3d29f4cf489567f85982e3735009bb6db61a.0
# or 
yarn add @tablecheck/eslint-config@1.5.1-canary.29.efab3d29f4cf489567f85982e3735009bb6db61a.0
yarn add @tablecheck/scripts@1.6.1-canary.29.efab3d29f4cf489567f85982e3735009bb6db61a.0

Sometimes the lint-staged eslint couldn't find the cypress configs correctly, this fixes that issue.
@SimeonC SimeonC added the patch Increment the patch version when merged label Oct 6, 2021
@SimeonC SimeonC self-assigned this Oct 6, 2021
@github-actions
Copy link

github-actions bot commented Oct 6, 2021

Unit Test Results

  2 files    9 suites   7s ⏱️
56 tests 56 ✔️ 0 💤 0

Results for commit 2f7ff40.

♻️ This comment has been updated with latest results.

@SimeonC SimeonC enabled auto-merge (rebase) October 11, 2021 02:17
@SimeonC SimeonC merged commit dceb450 into main Oct 11, 2021
@SimeonC SimeonC deleted the fix-precommit-eslint-cypress-testing-config branch October 11, 2021 02:21
@tablecheck-public-automation
Copy link
Collaborator

🚀 PR was released in @tablecheck/eslint-config@1.5.1, @tablecheck/scripts@1.7.1 🚀

@tablecheck-public-automation tablecheck-public-automation added the released This issue/pull request has been released. label Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants