fix(scripts): correctly fail runLint when errors are present #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staevs
previously approved these changes
Dec 15, 2021
daniellizik
previously approved these changes
Dec 15, 2021
SimeonC
force-pushed
the
eslint-bugfix
branch
from
2f84d6d
to
86bbb2d
Compare
staevs
previously approved these changes
Dec 15, 2021
daniellizik
previously approved these changes
Dec 15, 2021
SimeonC
force-pushed
the
eslint-bugfix
branch
from
c87cf53
to
17afe37
Compare
daniellizik
approved these changes
Dec 16, 2021
staevs
approved these changes
Dec 16, 2021
|
🚀 PR was released in |
tablecheck-public-automation
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the lint script would pass and exit with 0 even if there were eslint errors.
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @tablecheck/scripts@1.9.1-canary.38.7a88e8b81e009061cd1d3cde4abd9376e44ceac4.0 npm install @tablecheck/semantic-release-config@2.1.1-canary.38.7a88e8b81e009061cd1d3cde4abd9376e44ceac4.0 # or yarn add @tablecheck/scripts@1.9.1-canary.38.7a88e8b81e009061cd1d3cde4abd9376e44ceac4.0 yarn add @tablecheck/semantic-release-config@2.1.1-canary.38.7a88e8b81e009061cd1d3cde4abd9376e44ceac4.0