Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade all dependencies and add new consistent react import rule #47

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

SimeonC
Copy link
Collaborator

@SimeonC SimeonC commented Mar 23, 2022

πŸ“¦ Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/babel-preset@1.1.0-canary.47.2032631171.0
npm install @tablecheck/codemods@1.1.0-canary.47.2032631171.0
npm install @tablecheck/commitlint-config@1.1.0-canary.47.2032631171.0
npm install @tablecheck/eslint-config@1.7.0-canary.47.2032631171.0
npm install @tablecheck/eslint-plugin@1.2.0-canary.47.2032631171.0
npm install @tablecheck/scripts@1.11.0-canary.47.2032631171.0
npm install @tablecheck/semantic-release-config@2.5.0-canary.47.2032631171.0
npm install @tablecheck/scripts-utils@1.1.0-canary.47.2032631171.0
# or 
yarn add @tablecheck/babel-preset@1.1.0-canary.47.2032631171.0
yarn add @tablecheck/codemods@1.1.0-canary.47.2032631171.0
yarn add @tablecheck/commitlint-config@1.1.0-canary.47.2032631171.0
yarn add @tablecheck/eslint-config@1.7.0-canary.47.2032631171.0
yarn add @tablecheck/eslint-plugin@1.2.0-canary.47.2032631171.0
yarn add @tablecheck/scripts@1.11.0-canary.47.2032631171.0
yarn add @tablecheck/semantic-release-config@2.5.0-canary.47.2032631171.0
yarn add @tablecheck/scripts-utils@1.1.0-canary.47.2032631171.0

@SimeonC SimeonC added the minor Increment the minor version when merged label Mar 23, 2022
@github-actions
Copy link

github-actions bot commented Mar 23, 2022

Unit Test Results

βŸβ€„2 filesβ€„β€ƒβŸβ€„9 suites   10s ⏱️
55 tests 55 βœ”οΈβ€ƒ0 πŸ’€β€ƒ0 ❌

Results for commit da53a2e.

♻️ This comment has been updated with latest results.

@SimeonC SimeonC force-pushed the eslint-consistant-react-import branch 2 times, most recently from 6d22b29 to 4c90ea4 Compare March 23, 2022 10:26
@SimeonC SimeonC marked this pull request as ready for review March 24, 2022 04:00
@SimeonC SimeonC force-pushed the eslint-consistant-react-import branch 4 times, most recently from 362acd3 to e1b804d Compare March 24, 2022 06:29
daniellizik
daniellizik previously approved these changes Mar 24, 2022
Copy link

@wahidfarid wahidfarid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope of this PR, but trying to understand something πŸ™‡

judging by the amount of packages that use ^ it's an intentional decision. If we are always using explicit version numbers in our apps to avoid breakage, shouldn't we do the same in underlying packages like the tc react system? πŸ€” otherwise possible breaking changes can propagate from here into projects that use it

@SimeonC SimeonC merged commit 5e6c277 into main Mar 24, 2022
@SimeonC SimeonC deleted the eslint-consistant-react-import branch March 24, 2022 07:50
@tablecheck-public-automation tablecheck-public-automation added the released This issue/pull request has been released. label Mar 24, 2022
@SimeonC
Copy link
Collaborator Author

SimeonC commented Mar 24, 2022

Out of scope of this PR, but trying to understand something πŸ™‡

judging by the amount of packages that use ^ it's an intentional decision. If we are always using explicit version numbers in our apps to avoid breakage, shouldn't we do the same in underlying packages like the tc react system? πŸ€” otherwise possible breaking changes can propagate from here into projects that use it

We used to use explicit version numbers here too for that reason, but normally we found that that approach made it much harder to get small updates out for security or similar as we'd have to jump through the extra hoops. We decided (I decided?) that the security level stuff is handled by auditjs nicely. As for breaking changes - the versions get locked in package-lock.json files of the projects and with newer versions of npm don't update sub-deps unless you forcibly update them.

TLDR; the risk was determined to be smaller than the effort needed to constantly update them if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants