Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): the output of app based lib exports should be correctly generated #53

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

SimeonC
Copy link
Collaborator

@SimeonC SimeonC commented Apr 18, 2022

This deals with an issue where the absolute imports in an app were not getting transformed to relative and the an excess of definition files for irrelevant content.

πŸ“¦ Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/scripts@1.12.0-canary.53.2231759347.0
# or 
yarn add @tablecheck/scripts@1.12.0-canary.53.2231759347.0

… calculated

This deals with an issue where the absolute imports in an app were not getting transformed to relative and the an excess of definition files for irrelevant content.
@SimeonC SimeonC added the patch Increment the patch version when merged label Apr 18, 2022
@github-actions
Copy link

github-actions bot commented Apr 18, 2022

Unit Test Results

βŸβ€„2 filesβ€„β€ƒβŸβ€„9 suites   9s ⏱️
55 tests 55 βœ”οΈβ€ƒ0 πŸ’€β€ƒ0 ❌

Results for commit e9c89d6.

♻️ This comment has been updated with latest results.

staevs
staevs previously approved these changes Apr 27, 2022
SashaShostyr
SashaShostyr previously approved these changes Apr 27, 2022
Fixing some bugs and issues arising from using https://marketplace.visualstudio.com/items?itemName=Orta.vscode-jest

Fixes the storybook build which was missing a plugin dependency
@SimeonC SimeonC dismissed stale reviews from SashaShostyr and staevs via e9c89d6 April 27, 2022 08:15
@SimeonC
Copy link
Collaborator Author

SimeonC commented Apr 27, 2022

Have merged a second PR into this one so we only have one review. Will merge after CI passes as nothing will have changed so we don't need a second review process.

@SimeonC SimeonC merged commit e4678d4 into main Apr 27, 2022
@SimeonC SimeonC deleted the fix-app-build-lib-types-generation branch April 27, 2022 08:43
@tablecheck-public-automation
Copy link
Collaborator

πŸš€ PR was released in @tablecheck/scripts@1.11.3 πŸš€

@tablecheck-public-automation tablecheck-public-automation added the released This issue/pull request has been released. label Apr 27, 2022
@tablecheck-public-automation
Copy link
Collaborator

πŸš€ PR was released in @tablecheck/scripts@1.11.3 πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants