fix(scripts): issues with configuring typescript #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimeonC
force-pushed
the
fix-typescript-setup-on-install
branch
3 times, most recently
from
ffd1ac4
to
b569eea
Compare
SimeonC
force-pushed
the
fix-typescript-setup-on-install
branch
from
b569eea
to
32000b5
Compare
SimeonC
added
minor
SimeonC
force-pushed
the
fix-typescript-setup-on-install
branch
3 times, most recently
from
3c377f2
to
38bc2a4
Compare
SimeonC
force-pushed
the
fix-typescript-setup-on-install
branch
3 times, most recently
from
aa035ea
to
7b8cb65
Compare
Small issues that cropped up during actual installation of projects to do with paths to node_modules and working directories. Discovered when setting up tablekit-v3. Added some lint/precommit checks for package.json to attempt to smooth mismatches of versions in lerna. Update eslint ecmaVersion so we can have top level await (which is valid in almost everything now). Made the rules about loading eslint configs a lot less strict so that we can use slightly different rules in each monorepo and the precommit should use the same configs.
SimeonC
force-pushed
the
fix-typescript-setup-on-install
branch
from
7b8cb65
to
9713faf
Compare
staevs
reviewed
Jul 25, 2022
gazpachu
reviewed
Jul 27, 2022
staevs
approved these changes
Jul 27, 2022
gazpachu
approved these changes
Jul 27, 2022
tablecheck-public-automation
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small issues that cropped up during actual installation of projects to do with paths to node_modules and working directories. Discovered when setting up tablekit-v3.
Small feature added to the precommit to validate lerna sub-package versions all match up.
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @tablecheck/codemods@1.2.0-canary.68.2627312741.0 npm install @tablecheck/commitlint-config@1.2.0-canary.68.2627312741.0 npm install @tablecheck/eslint-config@1.8.0-canary.68.2627312741.0 npm install @tablecheck/scripts@2.3.0-canary.68.2627312741.0 # or yarn add @tablecheck/codemods@1.2.0-canary.68.2627312741.0 yarn add @tablecheck/commitlint-config@1.2.0-canary.68.2627312741.0 yarn add @tablecheck/eslint-config@1.8.0-canary.68.2627312741.0 yarn add @tablecheck/scripts@2.3.0-canary.68.2627312741.0