fix(scripts): non build tsc would fail if there is only one project #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An issue occured in tablekit-next where if there was only one typescript package the project build would fail with `Debug Failure. project /…/tablekit-next/tsconfig.json expected to have at least one output`
SimeonC
force-pushed
the
fix-single-lerna-project-lint
branch
from
4349f10
to
d978ecc
Compare
it isn't possible to just use the top level tsconfig? |
daniellizik
approved these changes
Jul 28, 2022
Basically, this PR does that - it takes the single child level tsconfig and replaces the top level config with it. For some reason I can't build a multi-project tsconfig if none of the children require each other and none of them are emitting anything (as is the case with linter) |
gazpachu
approved these changes
Jul 28, 2022
|
🚀 PR was released in |
tablecheck-public-automation
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue occured in tablekit-next where if there was only one typescript package the project build would fail with
Debug Failure. project /…/tablekit-next/tsconfig.json expected to have at least one outputThis PR fixes that issue by detecting if we are doing a "type check" (ie non-build) and if there is only one TS project in the lerna repo then we replace the top level config with a copy of the tsconfig in the child project so we then run a "single" run not a projects/workspace run (all paths are absolute so this has no issues).
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @tablecheck/scripts@2.3.1-canary.69.2751406635.0 # or yarn add @tablecheck/scripts@2.3.1-canary.69.2751406635.0