fix(scripts): precommit should use same configs as lint #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gazpachu
previously approved these changes
Aug 3, 2022
SimeonC
force-pushed
the
fix-precommit-eslint-config
branch
from
59c706f
to
4fe4883
Compare
gazpachu
previously approved these changes
Aug 3, 2022
Omiting the config param will correctly resolve to the same config as the normal lint. With the config param it’s resolving somewhere unknown. Have added an override for the lerna packages checker as in some cases it would be needed.
SimeonC
force-pushed
the
fix-precommit-eslint-config
branch
from
4fe4883
to
143dc38
Compare
staevs
approved these changes
Aug 3, 2022
gazpachu
approved these changes
Aug 5, 2022
|
🚀 PR was released in |
tablecheck-public-automation
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omiting the config param will correctly resolve to the same config as the normal lint. With the config param it’s resolving somewhere unknown.
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @tablecheck/scripts@2.3.3-canary.71.2787011566.0 # or yarn add @tablecheck/scripts@2.3.3-canary.71.2787011566.0