fix(scripts): noEmit appears to no longer be supported with references #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In typescript, if there are multiple references we cannot use `noEmit` so this needs to be turned off in those situations. Also enabling incremental mode to help speed up build/check times. Deps updated to fix audit issues.
SimeonC
force-pushed
the
fix-typescript-again
branch
from
46c9047
to
6acc5f3
Compare
daniellizik
approved these changes
Aug 5, 2022
staevs
approved these changes
Aug 5, 2022
|
🚀 PR was released in |
tablecheck-public-automation
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In typescript, if there are multiple references we cannot use
noEmit(see here and here) so this needs to be turned off in those situations. Also enabling incremental mode to help speed up build/check times.Found this issue again in tablekit-next branch which didn't seem to be fixed last time.
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @tablecheck/scripts@2.3.4-canary.72.2802458487.0 # or yarn add @tablecheck/scripts@2.3.4-canary.72.2802458487.0