fix: allow disabled as a boolean variable name exception
#97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commonly we have boolean props that want to be called `disabled` but according to rules we need to make these `isDisabled` or similar. This is a common conventional name and thus should be allowed.
SimonBystromTableCheck
previously approved these changes
Nov 30, 2023
SimeonC
force-pushed
the
allow-disabled-boolean-prop
branch
from
862b3e6
to
3f07faa
Compare
Added some basic tests for current cases for naming-convention as it’s very complicated.
SimeonC
force-pushed
the
allow-disabled-boolean-prop
branch
from
d2c1628
to
0bd333b
Compare
daniellizik
approved these changes
Dec 5, 2023
SimonBystromTableCheck
approved these changes
Dec 5, 2023
tablecheck-public-automation
added
the
released
|
🚀 PR was released in |
1 similar comment
|
🚀 PR was released in |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commonly we have boolean props that want to be called
disabledbut according to rules we need to make theseisDisabledor similar. This is a common conventional name and thus should be allowed.Also added a bunch of fixes and some simple tests for naming-convention.
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
npm install @tablecheck/eslint-config@8.2.4-canary.97.7058307546.0 # or yarn add @tablecheck/eslint-config@8.2.4-canary.97.7058307546.0