Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL support #93

Open
daniellizik opened this issue Apr 22, 2022 · 5 comments
Open

RTL support #93

daniellizik opened this issue Apr 22, 2022 · 5 comments

Comments

@daniellizik
Copy link
Collaborator

daniellizik commented Apr 22, 2022

input

  • input’s icon should have appropriate padding for rtl direction
  • label rtl positioning is broken

textarea

  • label rtl positioning is broken

checkbox

  • label rtl positioning is broken

radio button

  • label rtl positioning is broken

button

  • icon rtl spacing

phone input

  • Should always be LTR even when theme is RTL (numbers in RTL are still LTR, and switching the layout to RTL breaks the “country code” section
  • double check arabic numeric support

from https://tablecheck.atlassian.net/browse/BEXS-679

Findmitrey pushed a commit that referenced this issue May 5, 2022
wahidfarid pushed a commit that referenced this issue May 9, 2022
wahidfarid pushed a commit that referenced this issue May 9, 2022
wahidfarid pushed a commit that referenced this issue May 10, 2022
@wahidfarid
Copy link
Collaborator

progress:

  • input
  • textarea
  • checkbox
  • radio button
  • button
  • phone input

@wahidfarid wahidfarid mentioned this issue May 10, 2022
@gazpachu
Copy link
Contributor

@wahidfarid can we close this one?

@wahidfarid
Copy link
Collaborator

i'm not 100% sure 😓
i would have spent more effort here as part of working on RTL in the booking form. but that epic keeps getting delayed. we do eventually need to do it though, and there's no guarantee we will have transitioned the booking form to TK3 before then

@gazpachu
Copy link
Contributor

I we keep the ticket open, it'd be better to do the RTL on TK 3

@daniellizik
Copy link
Collaborator Author

@gazpachu i agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants