Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add base chain support #503

Merged
merged 1 commit into from
Jun 3, 2024
Merged

feat: add base chain support #503

merged 1 commit into from
Jun 3, 2024

Conversation

dtbuchholz
Copy link
Contributor

@dtbuchholz dtbuchholz commented May 23, 2024 •
edited
Loading

Summary

Adds Base Sepolia chain support. Closes ENG-859.

Details

How it was tested

Deployed to testnet

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dtbuchholz
Copy link
Contributor Author

cc @avichalp Base Sepolia addresses are above

@dtbuchholz dtbuchholz mentioned this pull request May 23, 2024
Merged
1 task
@dtbuchholz dtbuchholz merged commit 2ed51dd into main Jun 3, 2024
2 checks passed
@dtbuchholz dtbuchholz deleted the dtb/add-base branch June 3, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joewagner joewagner joewagner approved these changes

@sanderpick sanderpick Awaiting requested review from sanderpick sanderpick is a code owner

@carsonfarmer carsonfarmer Awaiting requested review from carsonfarmer carsonfarmer is a code owner

@brunocalza brunocalza Awaiting requested review from brunocalza

@avichalp avichalp Awaiting requested review from avichalp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtbuchholz @joewagner