Reformat webhooks #597
Reformat webhooks #597
Conversation
GOT-108 Add webhook handling to event processo
The hook could be defined in the chain config. Just fire at it in a go routine or similar. |
Signed-off-by: avichalp <hi@avichalp.me> Fix lint Signed-off-by: avichalp <hi@avichalp.me> Refactor nft views Signed-off-by: avichalp <hi@avichalp.me>
Signed-off-by: avichalp <hi@avichalp.me>
avichalp
force-pushed
the
avichalp/reformat-webhooks
branch
from
d472702
to
652d24d
Compare
Signed-off-by: avichalp <hi@avichalp.me>
| ContractAddr common.Address | ||
| TBLDocsURL string | ||
| BlockExplorerURL string | ||
| SupportsNFTView bool |
There was a problem hiding this comment.
Some block explorers like Etherscan have started to provide an NFT view. I believe this feature will be added to others eventually. Using this flag we can provide a link to the NFT view if available.
Signed-off-by: avichalp <hi@avichalp.me>
|
|
||
| txnURL := chains[int64(r.ChainID)].BlockExplorerURL + "/tx/" + r.TxnHash | ||
| docsURL := chains[int64(r.ChainID)].TBLDocsURL | ||
| err = tmpl.Execute(&c, webhookContentData{ |
There was a problem hiding this comment.
Enriches receipt with some more data such as links which will be useful for generating webhook contnet
| @@ -76,14 +80,162 @@ func sendWebhookRequest(ctx context.Context, url string, body interface{}) error | |||
| return nil | |||
| } | |||
|
|
|||
| type chain struct { | |||
| ID int64 | |||
There was a problem hiding this comment.
Is the ID field necessary? I'm not seeing it being used and also it seems a bit redundant because the key of the map is the chain ID
There was a problem hiding this comment.
I think Name is also not being used
pkg/eventprocessor/impl/webhook.go
Outdated
| var chains = map[int64]chain{ | ||
| 1: { | ||
| ID: 1, | ||
| Name: "Ethereum", |
There was a problem hiding this comment.
If you remove the Name field, you can add a comment on top of each chain to indicate the name of the chain
There was a problem hiding this comment.
Yea, good idea. Its not being used anywhere.
pkg/eventprocessor/impl/webhook.go
Outdated
| func getTableNFTViews(tableIDs tables.TableIDs, chainID tableland.ChainID) string { | ||
| var tableNFTURLs []string | ||
| for _, tableID := range tableIDs { | ||
| if !chains[int64(chainID)].SupportsNFTView { |
There was a problem hiding this comment.
worth creating a variable for storing the value of chains[int64(chainID)], so you don't do lots map lookup later? mostly to increase readability
pkg/eventprocessor/impl/webhook.go
Outdated
| SupportsNFTView bool | ||
| } | ||
|
|
||
| var chains = map[int64]chain{ |
There was a problem hiding this comment.
What happens if you change to map[tableland.ChainID]chain? does it avoid the int64 conversions?
Signed-off-by: avichalp <hi@avichalp.me>
Summary
Adds more context to webhooks content by adding hyperlinks for transactions, table ids and chain ids. Fixes GOT-108
Implementation overview
To add links to the tableland docs, and block explorers I have stored these links in the webhooks package against their corresponding chain ids.