implements POST /query #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Calza <brunoangelicalza@gmail.com>
brunocalza
force-pushed
the
bcalza/postquery
branch
from
8edf8e8
to
48d85ae
Compare
brunocalza
commented
Feb 21, 2024
Makefile
Outdated
| @@ -80,7 +80,7 @@ lint: | |||
| .PHONY: lint | |||
|
|
|||
| # OpenAPI | |||
| SPEC_URL=https://raw.githubusercontent.com/tablelandnetwork/docs/main/specs/validator/tableland-openapi-spec.yaml | |||
| SPEC_URL=https://raw.githubusercontent.com/tablelandnetwork/docs/bcalza/postquery/specs/validator/tableland-openapi-spec.yaml | |||
There was a problem hiding this comment.
points to the new spec. gotta change this before merge
| @@ -265,6 +270,65 @@ func (c *Controller) GetTableQuery(rw http.ResponseWriter, r *http.Request) { | |||
| _, _ = rw.Write(formatted) | |||
| } | |||
|
|
|||
| // PostTableQuery handles the POST /query call. | |||
| func (c *Controller) PostTableQuery(rw http.ResponseWriter, r *http.Request) { | |||
There was a problem hiding this comment.
new handler for POST /query
| @@ -61,6 +61,10 @@ func configureAPIV1Routes( | |||
| userCtrl.GetTableQuery, | |||
| []mux.MiddlewareFunc{middlewares.WithLogging, rateLim}, | |||
| }, | |||
| "QueryByStatementPost": { | |||
| return fmt.Errorf("get method: %s", err) | ||
| } | ||
|
|
||
| for _, method := range methods { |
There was a problem hiding this comment.
connects the route with the handler
brunocalza
commented
Feb 21, 2024
| @@ -256,6 +256,11 @@ func (c *Controller) GetTableQuery(rw http.ResponseWriter, r *http.Request) { | |||
| return | |||
| } | |||
|
|
|||
| if len(formatted) == 0 { | |||
There was a problem hiding this comment.
here it is @sanderpick
Signed-off-by: Bruno Calza <brunoangelicalza@gmail.com>
avichalp
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the
POST /queryspec defined at tablelandnetwork/docs#188Working example on
stagingcurl -v --json '{"statement": "SELECT * FROM system_txn_receipts LIMIT 1"}' https://staging.tableland.network/api/v1/querycc @dtbuchholz
Context
We're adding support for
POST /queryso queries can be sent via body request without the need of encoding the URL.Implementation overview
Generates the code based on a new spec and implements the controller in a similar way to
GET /query.