This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
LoginPage #194
Merged
LoginPage #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronCoplan
approved these changes
May 28, 2018
src/forms/FormTextInput.react.js
Outdated
| +onChange?: (SyntheticInputEvent<HTMLInputElement>) => void, | ||
| +onBlur?: (SyntheticInputEvent<HTMLInputElement>) => void, | ||
| ...FormInputProps, | ||
| +label?: string, | ||
| |}; | ||
|
|
||
| type State = {| | ||
| value: string | number, | ||
| |}; | ||
|
|
||
| class FormTextInput extends React.PureComponent<Props, State> { |
There was a problem hiding this comment.
Since we are removing the state, let's make this a pure component
| @@ -0,0 +1,13 @@ | |||
| //@flow | |||
| const strings = { | |||
There was a problem hiding this comment.
What is the advantage of having this in its own file?
There was a problem hiding this comment.
Mostly just to help reduce file length but also thought it might help at a later date if we decide to implement a more complex strings/translations system
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a reusable
LoginPagecomponent taken from the example site. Works well with libraries such as formik and uses astringsprop for editing displayed strings.LoginPageis wrapped in a new HOC that helps when working with form field touched and error states. It'll be handy for similar components in the future too.FormTextInput has had most of its internals removed as some are handled by React and props are now pretty much all imported and sent straight to Form.Input.