Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] bg-*color* overwrites font-color #1082

Closed
JustGreg opened this issue Mar 9, 2022 · 2 comments
Closed

[BUG] bg-*color* overwrites font-color #1082

JustGreg opened this issue Mar 9, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@JustGreg
Copy link

JustGreg commented Mar 9, 2022

Describe the bug

In utils/_colors.scss font-color is set to #ffffff !important.
Generated CSS would look like this:

.bg-dark {
  color: #ffffff !important;
  background: #1e293b !important;
}
.text-dark {
  color: #1e293b !important;
}
.bg-white {
  color: #ffffff !important;
  background: #ffffff !important;
}
.text-white {
  color: #ffffff !important;
}

The following HTML-Code will display a white text on a white background:

<div class="bg-white text-dark">text</div>

(this is because bg-white is declared after text-dark)

For some reason this part is missing in https://preview.tabler.io/dist/css/tabler.css

@JustGreg JustGreg added the bug Something isn't working label Mar 9, 2022
@rjd22
Copy link
Collaborator

rjd22 commented Mar 11, 2022

@JustGreg I could not replicate your issue. I did make a fix on it based on your feedback but @codecalm needs to check if my fix is appropriate:

#1086

@ishita-chandra
Copy link

PR-1112
I've added a pull request to fix the text colour being overwitten by bgcolour issue. Please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants