Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace !important modifier with more specific selectors ... #1100

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Replace !important modifier with more specific selectors ... #1100

merged 1 commit into from
Mar 28, 2022

Conversation

kathysledge
Copy link
Contributor

… and also replace hard coded border width with $border-width-wide variable.

…eplace hard coded border width with `$border-width-wide` variable.
@vercel
Copy link

vercel bot commented Mar 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tabler-ui/tabler/GxqVDn9Cyhxq3SMd41X6PZG1D9T5
✅ Preview: https://tabler-git-fork-df2-replace-important-modifier-7f2f27-tabler-ui.vercel.app

@rjd22
Copy link
Collaborator

rjd22 commented Mar 25, 2022

I'm leaving this one for @codecalm I don't mind but since this is more of a style change maybe @codecalm has a opinion in this.

@kathysledge
Copy link
Contributor Author

Sounds good @rjd22. I haven't tested it but it should also make it easier for rtl styles to move the highlight to the right.

@kathysledge
Copy link
Contributor Author

RTL style works fine with it 👍

Arabic example:
Screenshot_20220325_081255

@codecalm codecalm merged commit 6680ef9 into tabler:main Mar 28, 2022
@codecalm
Copy link
Member

thank you for help! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants