Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text color in dark version of navbar #1569

Merged
merged 5 commits into from May 14, 2023
Merged

Fix text color in dark version of navbar #1569

merged 5 commits into from May 14, 2023

Conversation

codecalm
Copy link
Member

@codecalm codecalm commented May 14, 2023

fixes #1568

@changeset-bot
Copy link

changeset-bot bot commented May 14, 2023

🦋 Changeset detected

Latest commit: 2e36294

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tabler/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tabler ✅ Ready (Inspect) Visit Preview May 14, 2023 6:54pm

@kevinpapst
Copy link
Collaborator

kevinpapst commented May 14, 2023

such a tiny code piece leads to such a big change. looking good now 👍

@codecalm
Copy link
Member Author

@kevinpapst I don't know why I haven't seen this before 🫣

@kevinpapst
Copy link
Collaborator

Sorry for not testing earlier 😢
I guess I will post some more smaller issues about the dark mode.

I am currently implementing the changes in my "symfony tabler bundle" and in my app.
Do I have to add the data-bs-theme="dark" in the navbars or is it still navbar-dark class?

@codecalm
Copy link
Member Author

Bootstrap will remove navbar-dark in next release so I unify it with Tabler

@codecalm codecalm changed the title Fix bugs in dark mode for better user experience Fix text color in dark version of navbar May 14, 2023
Copy link
Collaborator

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and all test cases work now 👍

@codecalm codecalm merged commit 056df18 into dev May 14, 2023
3 checks passed
@codecalm codecalm deleted the dev-dark-mode-fixes branch May 14, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Beta 18 - Dark navbars are broken
2 participants