Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit installation using pnpm #728

Merged
merged 1 commit into from
Dec 5, 2020
Merged

Permit installation using pnpm #728

merged 1 commit into from
Dec 5, 2020

Conversation

cedric-anne
Copy link
Contributor

We are currently trying to refactor our UI using tabler.

On my machine, since I added the @tabler/core package, npm install takes up to 12 minutes (was about 30 seconds before this change). I wanted to try pnpm, but it does not handle short commit hash in dependencies specs, and fails with this message:  ERROR  Could not resolve c63aebc to a commit of git://github.com/twbs/bootstrap.git..

Using the full hash could permit usage of pnpm to fetch your wonderful creation.

@codecalm
Copy link
Member

codecalm commented Dec 5, 2020

thank you! <3 I didn't know that is difference between short and full hash :)

@codecalm codecalm merged commit 519386c into tabler:dev Dec 5, 2020
@cedric-anne cedric-anne deleted the patch-1 branch December 6, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants