Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text body not overruling dark mode properly #944

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Conversation

rjd22
Copy link
Collaborator

@rjd22 rjd22 commented Nov 22, 2021

No description provided.

@rjd22 rjd22 requested a review from codecalm November 22, 2021 17:43
Copy link
Collaborator

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that I have a rule like this is my project to fix the issue:

@include dark-mode {
    /* list items */
    .text-body {
        color: $dark-mode-text!important;
    }
}

I'd appreciate if that gets fixed in tabler directly. There are some other issues with the dark mode, I'll post them for discussion in a new issue.

@rjd22 rjd22 merged commit 3d986ee into dev Nov 22, 2021
@rjd22 rjd22 deleted the fix-text-body-dark-mode branch November 22, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants