[#161847] Rake tasks for adding new PriceGroups to ScheduleRules #3594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that aren't currently associated with a schedule rule
giladshanan
reviewed
Jul 24, 2023
giladshanan
reviewed
Jul 24, 2023
This also creates a `price_group` rake task and removes the `schedule_rule` one
Co-authored-by: Gilad Shanan <30355046+giladshanan@users.noreply.github.com>
giladshanan
reviewed
Jul 25, 2023
There was a problem hiding this comment.
There are a handful of other places where PriceGroups are created, can you take a look and see if we can use the new method instead:
demo_seed.rakerails_helper.rb- school-specific seed files like
vendor/engines/umass_corum/db/seeds.rb(we can update those as we pull this down into the school repos)
giladshanan
reviewed
Jul 26, 2023
giladshanan
reviewed
Jul 26, 2023
giladshanan
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
When a global price group is created, it needs to be added to all the schedule rules for it to appear on the UI for each product.
This created a rake tasks which does that.