[#161789] Access List Enhancements #3983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladshanan
requested changes
Jan 19, 2024
giladshanan
reviewed
Jan 23, 2024
giladshanan
requested changes
Jan 23, 2024
There was a problem hiding this comment.
@LeticiaErrandonea I left some suggestions for reorganizing the code here - please let me know if they are clear enough or not. It may be easier to talk through in real time
LeticiaErrandonea
force-pushed
the
161789-access_list_enhancements
branch
from
cb9702c
to
48973a3
Compare
giladshanan
reviewed
Jan 26, 2024
There was a problem hiding this comment.
@LeticiaErrandonea a couple more small questions for you, almost there!
| def search | ||
| @product_users = all_product_users(params[:search]).paginate(page: params[:page], per_page: USERS_PER_PAGE) | ||
|
|
||
| @search_action_performed = params[:search] |
There was a problem hiding this comment.
Let's called this @search_term since we're not using the boolean any more
| - if @product.has_product_access_groups? | ||
| = form_for @product, url: [current_facility, @product, :update_restrictions], method: :put do |f| | ||
| = render "table", f: f | ||
| = f.submit text("update", plural_label: ProductAccessGroup.model_name.human.pluralize), |
There was a problem hiding this comment.
Does this translation still work in the new partial?
There was a problem hiding this comment.
Good catch!
| @@ -20,22 +20,4 @@ | |||
| = text("import_button") | |||
| %span{ style:"display:none" }= f.file_field :file, onchange: "form.submit()" | |||
|
|
|||
| - if @product_users.nil? | |||
| - elsif @product_users.empty? | |||
| %p.notice= text("none") | |||
There was a problem hiding this comment.
I think there's an entry for this in config/locales/views/admin/en.product_users.yml:7 that can be removed now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Screenshot
Additional Context
Optional. Feel free to add/modify additional headers as appropriate, e.g. "Refactorings", "Concerns".