Ensure tmp exists at app root, and use it #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 6, 2016 09:27
This avoids writing predictable filenames to /tmp (where Dir.tmpdir often points on Linux), and writes to a directory that we should count on being writable (we have found /tmp not always writable to the app in some envionments).
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is partially from https://github.com/tablexi/nucore-dartmouth/pull/38. We need
tmpto exist at the app root, and it does, though it seems it's only because gems likesprocketsandletter_openerwill create it if it's not there.This also reworks the only code I'm aware of that was relying on
Dir.tmpdir, in journal creation. With this in place, some of the overrides in the DC fork may become redundant.